Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added Elestio as one-click deploy option #1929

Closed

Conversation

kaiwalyakoparkar
Copy link

This PR introduces new one-click deployment option - Elestio

Fixes #1928

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@kaiwalyakoparkar kaiwalyakoparkar requested a review from a team as a code owner September 13, 2024 07:27
@MarkEWaite
Copy link
Contributor

MarkEWaite commented Sep 13, 2024

I strongly prefer that links to public cloud hosting services be offered from the Jenkins download page rather than being offered from the docker repository README file.

The Jenkins download page already includes public cloud hosting instructions for:

The improve this page link on the downloads page will take you to the file that needs to be extended.

If we add the public cloud hosting providers to the Docker documentation, we should also add them to the helm chart documentation. I think it is better to place public cloud provider links in the central location rather than spread it into multiple repositories. We could link from the Docker and Helm chart documentation to that location as a way to increase visibility.

Copy link
Contributor

@MarkEWaite MarkEWaite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MarkEWaite
Copy link
Contributor

We discussed this in the Platform SIG meeting 24 Sep 2024 and decided this needs to be proposed to the downloads page rather than the container image documentation.

@MarkEWaite MarkEWaite closed this Sep 24, 2024
@kaiwalyakoparkar
Copy link
Author

Thanks for letting me know @MarkEWaite, Can you please share the link for the downloads page? I will make a pr to it :)

@MarkEWaite
Copy link
Contributor

Sure. Here it is:

The improve this page link on the downloads page will take you to the file that needs to be extended.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding Elestio as deployment option
2 participants